Run component updates in the background #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to make it non-background the first time the image is run? (empty DB). Reason is: enabling workflow modules will trigger a list of errors if this command is not run at least once. Even better: make it optional (background option) via env var setting? |
… BACKGROUND_COMPONENT_UPDATES
|
@ostefano good catch! I updated the PR to only run this in the background if the database was already initialised and then only if the BACKGROUND_COMPONENT_UPDATES env var is set |
|
@ostefano I think that takes care of all issues while avoiding giving users a foot cannon 👍 |
|
@oivindoh LGTM. Will merge as soon as I get some spare cycles to work on this 👍 |
|
Merged in other branch (required some refactory) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, starting the image after bumping version numbers tends to be stuck for a very long time on component updates.
This PR runs these updates in the background rather than blocking startup waiting for the updates to be complete.
I don't really see a reason to wait for these to finish before proceeding with that we do after, and this change potentially reduces update downtime by a lot, depending on how time-consuming these processes are per update.